QemuHCK: add --aio-native/--aio-threads CLI options#1029
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring the drive AIO state (--aio-native and --aio-threads) for virtual disks, including CLI option parsing, validation to prevent conflicting configurations, and propagation of these settings to the platform options. Feedback is provided regarding a missing update to the merge! method in HLKPlatformClientsOptions to ensure the new drive_aio_state property is correctly merged.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| Models::HLKPlatform.from_json_file(platform_json, logger) | ||
| platform = Models::HLKPlatform.from_json_file(platform_json, logger) | ||
| platform.clients_options.drive_aio_state = options.test.drive_aio_state |
There was a problem hiding this comment.
I think about something like --fs-test-image-format but for aio. Is there any reason to make drive_aio_state as a state and add it to the client? What do you think?
There was a problem hiding this comment.
Agreed, I reworked this
| "drive_aio_state": { | ||
| "native": { | ||
| "drive_cache_options": [ | ||
| ",cache=none", |
There was a problem hiding this comment.
Why force cache = none?
There was a problem hiding this comment.
This matches the QEMU command from the Kar tests logs. And according to info from the internet, it is also recommended to use cache=none with aio=native
elizashurov
force-pushed
the
VIRTWINKVM-2256
branch
2 times, most recently
from
8a9e657 to
348364d
Compare
Add --aio-native/--aio-threads CLI flags to set disk AIO mode. Both modes force cache=none. Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
elizashurov
force-pushed
the
VIRTWINKVM-2256
branch
from
348364d to
e105896
Compare
elizashurov
changed the title
2 participants
Adds CLI flags and setup-manager support for aio=native/aio=threads on
virtual disks. Both modes also set cache=none.